fix: each router handle stores the entire connections map #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
changed the title
Sidddddarth
changed the title
ktgowtham
approved these changes
Sep 18, 2024
lvrach
approved these changes
Sep 18, 2024
cisse21
approved these changes
Sep 18, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.34.x #5109 +/- ##
==================================================
- Coverage 74.80% 74.77% -0.03%
==================================================
Files 435 435
Lines 50436 50438 +2
==================================================
- Hits 37728 37716 -12
+ Misses 10241 10237 -4
- Partials 2467 2485 +18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each router handle stored the connections for all destinations, even those of which were not of the same destType!
It's now filtered so router handles only store connection details of destinations of the same destType.
Linear Ticket
Resolves PIPE-1540
Security